-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webhooks/datavolume: comment about remove check of claim adoption #3481
Conversation
There is an open issue in github to remove the claim adoption feature gate: kubevirt#3480 Once the FG is removed we should remove the check in the webhook that verifies if it allowed to have an existing PVC. Signed-off-by: Shelly Kagan <[email protected]>
/lgtm |
/approve |
@awels: Overrode contexts on behalf of awels: pull-containerized-data-importer-non-csi-hpp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…bevirt#3481) There is an open issue in github to remove the claim adoption feature gate: kubevirt#3480 Once the FG is removed we should remove the check in the webhook that verifies if it allowed to have an existing PVC. Signed-off-by: Shelly Kagan <[email protected]>
…bevirt#3481) There is an open issue in github to remove the claim adoption feature gate: kubevirt#3480 Once the FG is removed we should remove the check in the webhook that verifies if it allowed to have an existing PVC. Signed-off-by: Shelly Kagan <[email protected]>
There is an open issue in github to remove the claim adoption feature gate:
#3480 Once the FG is removed we should remove the check in the webhook that verifies if it allowed to have an existing PVC.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: